-
Notifications
You must be signed in to change notification settings - Fork 74
Add messages for motion primitives #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add messages for motion primitives #228
Conversation
These messages should reflect the motion primitives supported by most industrial robots.They are meant to being extended in the future in order to support a larger variety of motion implementations. The motivation is to support executing robot motions as they are traditionally programmed: A series of primitives such as `LIN`, `PTP`, `CIRC`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start, I only have that one question re. documenting a teeeeny bit more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
(cherry picked from commit 16742c2)
These messages should reflect the motion primitives supported by most industrial robots.They are meant to being extended in the future in order to support a larger variety of motion implementations.
The motivation is to support executing robot motions as they are traditionally programmed: A series of primitives such as
LIN
,PTP
,CIRC
.This PR should support ros-controls/ros2_controllers#1636